Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:stop failing wf when deleting artifacts #351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix:stop failing wf when deleting artifacts #351

wants to merge 1 commit into from

Conversation

kdoroszko-splunk
Copy link
Contributor

@kdoroszko-splunk kdoroszko-splunk commented Dec 16, 2024 •
edited
Loading

Description

Sometimes geekyeggo/delete-artifact@v5 fails to delete artifacts which causes the whole pipeline to fail (example workflow). This PR sets the flag failOnError: false to prevent this from happening.
It seems the rootacause is in geekyeggo/delete-artifact@v5 action - similar issue was already reported: GeekyEggo/delete-artifact#22

Checklist

  • README.md has been updated or is not required
  • push trigger tests
  • manual release test
  • automated releaes test
  • pull request trigger tests
  • schedule trigger tests
  • workflow errors/warnings reviewed and addressed

Testing done

https://github.com/splunk/splunk-add-on-for-tomcat/pull/445

@kdoroszko-splunk kdoroszko-splunk changed the base branch from develop to main December 16, 2024 09:41
@kdoroszko-splunk kdoroszko-splunk changed the title Fix/stop failing wf when deleting artifacts fix:stop failing wf when deleting artifacts Dec 16, 2024
@kdoroszko-splunk kdoroszko-splunk marked this pull request as ready for review December 16, 2024 10:44
@kdoroszko-splunk kdoroszko-splunk requested a review from a team as a code owner December 16, 2024 10:44
mkolasinski-splunk
mkolasinski-splunk approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@mkolasinski-splunk mkolasinski-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide rootcause analysis in description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkolasinski-splunk mkolasinski-splunk mkolasinski-splunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdoroszko-splunk @mkolasinski-splunk